Messages in this thread | | | Date | Sat, 02 May 2009 18:16:38 +0200 | From | Helge Deller <> | Subject | Re: [PATCH 3/5] parisc: use new macros for .data.init_task. |
| |
Kyle McMartin wrote: > On Sat, May 02, 2009 at 07:13:37AM +0200, Helge Deller wrote: >> I think this patch is wrong, although it is theoretically correct. >> >> IIRC, gcc on hppa is not able to provide an alignment >= 8k, which is >> why we have done the 16k alignment inside the linker script. >> So, I think this change will prevent the parisc kernel to boot up. >> Needs testing. >> > > I think you're confusing this with the 8-byte maximum alignment from > kmalloc and on-stack that prevents us from just using a 16-byte aligned > word as a lock on pa1.1?
No, I was not confusing it with the 8byte-alignment.
I really meant that a > 8k alignment was not possible. I tried exactly the same stuff once and failed. I think the restriction came from hpux compatibility or some old gas...
Anyway, I just tried some assembly and it seems to work.
> The patch I trimmed from this mail looks correct to me.
If you apply it and it boots OK for you, I'm fine.
Helge
| |