Messages in this thread |  | | | Date | Tue, 19 May 2009 12:00:00 -0700 (PDT) | | From | Martin Knoblauch <> | | Subject | Re: Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c |
| |
----- Original Message ---- > From: Linus Torvalds <torvalds@linux-foundation.org> > To: Martin Knoblauch <spamtrap@knobisoft.de> > Cc: Matt Mackall <mpm@selenic.com>; Ingo Molnar <mingo@elte.hu>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org> > Sent: Tuesday, May 19, 2009 8:24:48 PM > Subject: Re: Rgeression: 2.6.30-rc6-git3 build error - ICE from drivers/char/random.c > > > > On Tue, 19 May 2009, Linus Torvalds wrote: > > > > I guess getting rid of 'jiffies' is also worth it. Even at its very worst, > > 'get_cycles()' should return jiffy-level information, so adding in jiffies > > doesn't add anything to it. > > I take that back. If there isno TSC at all, "get_cycles()" might just be > returning zero. So the jiffies fallback is probably better than nothing. > > So I'll just remove the (long)&ret part. And you already said that that > fixed it both with my previous patch and without, so I guess it's already > tested. > > Linus
correct. The original code with (long)&ret removed yields:
hash[0] += current->pid + jiffies + get_cycles();
and compiles OK.
Tested-by: Martin Knoblauch <spamtrap@knobisoft.de>
Cheers Martin
|  |