[lkml]   [2009]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tracing: add trace_event_read_lock()
Frederic Weisbecker wrote:
> On Mon, May 18, 2009 at 07:35:34PM +0800, Lai Jiangshan wrote:
>> I found that there is nothing to protect event_hash in
>> ftrace_find_event().
> Actually, rcu protects it, but not enough. We have neither
> synchronize_rcu() nor rcu_read_lock.

We have no rcu_read_lock(), RCU can not protects it.

> So we protect against concurrent hlist accesses.
> But the event can be removed when a module is unloaded,
> and that can happen between the time we get the event output
> callback and the time we actually use it.


> It could be more fine grained.

I think it's fine-grained enough, write-side(modules loading/unloading)
is happened rarely. trace_event_read_lock() will not sleep very likely.


> We could have a per event rwsem, and also place the
> protected read section only in trace_print_entry() which is the only racy window.

print_trace_line() is the only racy window.
So I just protect print_trace_line()(except __ftrace_dump())

I protect loops which call print_trace_line(), it
reduces invoke-times:

while (...) {


> But I'm not sure it's that worthy since event removal is a rare thing.
> So I guess this patch is fine.

 \ /
  Last update: 2009-05-19 04:11    [W:0.065 / U:4.900 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site