Messages in this thread | | | Subject | Re: [PATCH] Acer Aspire One Fan Control | From | Joe Perches <> | Date | Mon, 18 May 2009 13:20:32 -0700 |
| |
On Mon, 2009-05-18 at 20:04 +0200, Peter Feuerer wrote: > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > new file mode 100644 > index 0000000..99ae2e6 > --- /dev/null > +++ b/drivers/platform/x86/acerhdf.c > @@ -0,0 +1,530 @@ [] > +#define acerhdf_printk(loglevel, fmt, args...) \ > + printk(loglevel "acerhdf: " fmt, ## args); > + > +#define acerhdf_notice(fmt, args...) \ > + acerhdf_printk(KERN_NOTICE, fmt, ## args); > + > +#define acerhdf_error(fmt, args...) \ > + acerhdf_printk(KERN_ERR, fmt, ## args);
Could you please not create new prefixes for printk?
I think:
#define pr_fmt(fmt) "acerhdf:" fmt and use of pr_err and pr_notice would be better.
cheers, Joe
| |