Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( | Date | Mon, 18 May 2009 17:48:40 +0200 |
| |
On Monday 18 May 2009 17:41:28 Joe Perches wrote: > On Mon, 2009-05-18 at 16:12 +0200, Bartlomiej Zolnierkiewicz wrote: > > On Monday 18 May 2009 04:21:08 Joe Perches wrote: > > > Mostly mechanical conversion of printk's > > Hmm.. less mechanical conversion using also dev_*() macros where suitable > > would be much better... > > How's about fixing pr_devel() which currently doesn't seem to be used > > by anything inside kernel to not depend on DEBUG in separate pre-patch > > and then using it instead of pr_debug()? > > How about deferring the "printk(KERN_DEBUG" to something else > and doing the mechanical conversion to core as a first pass, > followed by core pr_<foo> to dev_<foo> where appropriate > as a second pass?
Fine with me.
> What do you think is appropriate for pr_<foo> to dev_<foo> > conversions?
printk()s using drive->name or hwif->name
Thanks, Bart
| |