Messages in this thread |  | | | Date | Mon, 18 May 2009 14:11:08 +0400 | | From | Sergei Shtylyov <> | | Subject | Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( |
| |
Hello.
Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com> >
This patch creates lines > 80 chars long, co no ACK this time. > diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c > index a6edb0d..d7c4f5c 100644 > --- a/drivers/ide/ide-floppy.c > +++ b/drivers/ide/ide-floppy.c > [...] > @@ -428,17 +428,15 @@ static int ide_floppy_get_capacity(ide_drive_t *drive) > memcpy(&floppy->cap_desc, cap_desc, 8); > > if (!length || length % 512) { > - printk(KERN_NOTICE PFX "%s: %d bytes block size" > - " not supported\n", drive->name, length); > + pr_notice(PFX "%s: %d bytes block size not supported\n", >
Line longer than 80 characters...
> + drive->name, length); > } else { > floppy->blocks = blocks; > floppy->block_size = length; > floppy->bs_factor = length / 512; > if (floppy->bs_factor != 1) > - printk(KERN_NOTICE PFX "%s: Warning: " > - "non 512 bytes block size not " > - "fully supported\n", > - drive->name); > + pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n", >
Again.
> + drive->name); > drive->capacity64 = > floppy->blocks * floppy->bs_factor; > rc = 0; > diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c > index 138c42d..bf3c128 100644 > --- a/drivers/ide/ide-tape.c > +++ b/drivers/ide/ide-tape.c > @@ -756,8 +756,8 @@ static ide_startstop_t idetape_do_request(ide_drive_t *drive, > > if (!blk_special_request(rq)) { > /* We do not support buffer cache originated requests. */ > - printk(KERN_NOTICE "ide-tape: %s: Unsupported request in " > - "request queue (%d)\n", drive->name, rq->cmd_type); > + pr_notice("ide-tape: %s: Unsupported request in request queue (%d)\n", >
And again.
MBR, Sergei
|  |