Messages in this thread | | | Date | Sun, 17 May 2009 14:17:00 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 3/10 -tip] x86: Add cpufeatures for Advanced Power Management |
| |
On Fri, 15 May 2009, Jaswinder Singh Rajput wrote: > > Do you really believe that open-coding x86_capability[9] in .../common.c > > is better than the open-coding in ../powernow-k8.c ? > > > > BTW, then how you can set x86_capability[9] in one shot ? do you want me > to set each bit with set_cpu_cap() ?
Using "9" as an array index is the point. This needs to be a constant near the other constants which describe the bits and a big fat comment.
Thanks,
tglx
| |