Messages in this thread | | | Subject | Re: [PATCH 2/6] drivers/ide: Convert printk(KERN_INFO to pr_info( | From | Joe Perches <> | Date | Sun, 17 May 2009 19:31:33 -0700 |
| |
On Sun, 2009-05-17 at 19:21 -0700, Joe Perches wrote: > diff --git a/drivers/ide/aec62xx.c b/drivers/ide/aec62xx.c > index 878f8ec..d2f9293 100644 > --- a/drivers/ide/aec62xx.c > +++ b/drivers/ide/aec62xx.c > @@ -273,8 +273,8 @@ static int __devinit aec62xx_init_one(struct pci_dev *dev, const struct pci_devi > unsigned long dma_base = pci_resource_start(dev, 4); > > if (inb(dma_base + 2) & 0x10) { > - printk(KERN_INFO DRV_NAME " %s: AEC6880%s card detected" > - "\n", pci_name(dev), (idx == 4) ? "R" : ""); > + pr_info(DRV_NAME " %s: AEC6880%s card detected\n" > + pci_name(dev), (idx == 4) ? "R" : ""); > d.udma_mask = ATA_UDMA6; > } > }
Sorry, this one is bad. It's missing a comma between the end of the format string and pci_name.
I edited it in-place and neglected to remove the backup file. git send-email sent the corrected patch and the backup file.
The other [patch 2/6] is correct.
| |