lkml.org 
[lkml]   [2009]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH 3/7] ide: merge ide_disk_special() into do_special()
Date
On Thursday 14 May 2009 14:23:32 Sergei Shtylyov wrote:
> Hello.
>
> Joe Perches wrote:
>
> >>While at it:
> >>- change debug printk() level to KERN_DEBUG
> >>- update documentation
>
> >>There should be no functional changes caused by this patch.
>
> >>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >>---
> >> drivers/ide/ide-io.c | 44 ++++++++++++++++++--------------------------
> >> 1 file changed, 18 insertions(+), 26 deletions(-)
>
> >>Index: b/drivers/ide/ide-io.c
> >>===================================================================
> >>--- a/drivers/ide/ide-io.c
> >>+++ b/drivers/ide/ide-io.c
> >>@@ -184,11 +184,28 @@ static void ide_tf_set_setmult_cmd(ide_d
>
> > []
>
> >>+#ifdef DEBUG
> >>+ printk(KERN_DEBUG "%s: %s: 0x%02x\n", drive->name, s->all);
> >>+#endif
>
> > pr_debug?
>
> Yes, and the number of arguments doesn't correspond to the number of the
> format specifiers.

Ugh :) Fixed in the revised version (interdiff below)...

When it comes to pr_debug() & co. I will warmly welcome patches converting
drivers/ide/*.[ch] to use them.
...
v2:
- fix DEBUG build (noticed by Sergei)
...

diff -u b/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
--- b/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -198,7 +198,7 @@
struct ide_cmd cmd;

#ifdef DEBUG
- printk(KERN_DEBUG "%s: %s: 0x%02x\n", drive->name, s->all);
+ printk(KERN_DEBUG "%s: %s: 0x%02x\n", drive->name, __func__, s->all);
#endif
if (drive->media != ide_disk) {
s->all = 0;

\
 
 \ /
  Last update: 2009-05-17 19:01    [from the cache]
©2003-2011 Jasper Spaans