Messages in this thread | | | Date | Sat, 16 May 2009 09:13:05 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH block#for-2.6.31 2/3] block: set rq->resid_len to blk_rq_bytes() on issue |
| |
On Sat, May 16, 2009 at 12:18:42AM +0900, Tejun Heo wrote: > In commit c3a4d78c580de4edc9ef0f7c59812fb02ceb037f, while introducing > rq->resid_len, the default value of residue count was changed from > full count to zero. The conversion was done under the assumption that > when a request fails residue count wasn't defined. However, Boaz and > James pointed out that this wasn't true and the residue count should > be preserved for failed requests too. > > This patchset restores the original behavior by setting rq->resid_len > to blk_rq_bytes(rq) on issue and restoring explicit clearing in > affected drivers. While at it, take advantage of the fact that > rq->resid_len is set to full count where applicable. > > * ide-cd: rq->resid_len cleared on pc success > > * mptsas: req->resid_len cleared on success > > * sas_expander: rsp/req->resid_len cleared on success > > * mpt2sas_transport: req->resid_len cleared on success > > * ide-cd, ide-tape, mptsas, sas_host_smp, mpt2sas_transport, ub: take > advantage of initial full count to simplify code
ACK the ide-{cd,tape} bits.
Acked-by: Borislav Petkov <petkovbb@gmail.com>
I've converted the ide-atapi part to rq->resid_len and from what I see, the changes are compatible with the latest semantics of rq->resid_len but it won't hurt if you could take a look too :) :
http://git.kernel.org/?p=linux/kernel/git/bp/bp.git;a=commit;h=077e6dba20e74a455a0452379d2a965c7e1b01ad
On a side note, ide_pc_intr() does some transfer padding but that doesn't affect rq->resid_len returning the remaining bytecount back up to block layer.
[..]
Thanks.
-- Regards/Gruss, Boris.
| |