lkml.org 
[lkml]   [2009]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 09/11] drivers/scsi: Convert #ifdef DEBUG printk(KERN_DEBUG to pr_debug(
From
Date
On Fri, 2009-05-15 at 10:59 -0700, Joe Perches wrote:
> From: Joe Perches <joe@perches.com>
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/scsi/aha1542.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> index 8059494..29d5118 100644
> --- a/drivers/scsi/aha1542.c
> +++ b/drivers/scsi/aha1542.c
> @@ -509,9 +509,7 @@ static void aha1542_intr_handle(struct Scsi_Host *shost)
> if (mbistatus == 3)
> continue; /* Aborted command not found */
>
> -#ifdef DEBUG
> - printk(KERN_DEBUG "...done %d %d\n", mbo, mbi);
> -#endif
> + pr_debug("...done %d %d\n", mbo, mbi);

This one looks dangerous ... that's a per trigger printk from interrupt
context. That's a lot of stuff to bung in the log buffer for a normal
operating case (which is pretty interrupt heavy). What does this do to
system responsiveness?

James




\
 
 \ /
  Last update: 2009-05-15 20:59    [W:0.779 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site