Messages in this thread | | | Subject | Re: [PATCH 09/11] drivers/scsi: Convert #ifdef DEBUG printk(KERN_DEBUG to pr_debug( | From | James Bottomley <> | Date | Fri, 15 May 2009 18:56:46 +0000 |
| |
On Fri, 2009-05-15 at 10:59 -0700, Joe Perches wrote: > From: Joe Perches <joe@perches.com> > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/scsi/aha1542.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c > index 8059494..29d5118 100644 > --- a/drivers/scsi/aha1542.c > +++ b/drivers/scsi/aha1542.c > @@ -509,9 +509,7 @@ static void aha1542_intr_handle(struct Scsi_Host *shost) > if (mbistatus == 3) > continue; /* Aborted command not found */ > > -#ifdef DEBUG > - printk(KERN_DEBUG "...done %d %d\n", mbo, mbi); > -#endif > + pr_debug("...done %d %d\n", mbo, mbi);
This one looks dangerous ... that's a per trigger printk from interrupt context. That's a lot of stuff to bung in the log buffer for a normal operating case (which is pretty interrupt heavy). What does this do to system responsiveness?
James
| |