Messages in this thread | | | Date | Fri, 15 May 2009 19:37:20 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/3] Introduce "struct wait_info" to simplify wait_task*() pathes |
| |
* Vitaly Mayatskikh <v.mayatskih@gmail.com> wrote:
> At Wed, 13 May 2009 11:13:58 -0700 (PDT), Roland McGrath wrote: > > > What's the benefit of this? Those parameters are probably > > happily in registers and compiled well, I would guess. Adding > > more memory copying does not seem like a benefit. Have you > > verified that your change reduces code size or something like > > that? > > Yeah, I was wrong. There's no benefit in size of .text
but there's a lot of benefit in cleanliness - just look at the simplification of the prototypes.
Ingo
| |