lkml.org 
[lkml]   [2009]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH block#for-2.6.31 3/3] bio: always copy back data for copied kernel requests
When a read bio_copy_kern() request fails, the content of the bounce
buffer is not copied back. However, as request failure doesn't
necessarily mean complete failure, the buffer state can be useful.
This behavior is also inconsistent with the user map counterpart and
causes the subtle difference between bounced and unbounced IO causes
confusion.

This patch makes bio_copy_kern_endio() ignore @err and always copy
back data on request completion.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
---
fs/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: block/fs/bio.c
===================================================================
--- block.orig/fs/bio.c
+++ block/fs/bio.c
@@ -1198,7 +1198,7 @@ static void bio_copy_kern_endio(struct b
char *addr = page_address(bvec->bv_page);
int len = bmd->iovecs[i].bv_len;

- if (read && !err)
+ if (read)
memcpy(p, addr, len);

__free_page(bvec->bv_page);

\
 
 \ /
  Last update: 2009-05-15 17:23    [W:0.072 / U:0.124 seconds]
©2003-2011 Jasper Spaans. Advertise on this site