lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sysrq, intel_fb: fix sysrq g collision
    On Thu, 14 May 2009 17:58:11 -0500
    Jason Wessel <jason.wessel@windriver.com> wrote:

    > Commit 79e539453b34e35f39299a899d263b0a1f1670bd introduced a
    > regression where you cannot use sysrq 'g' to enter kgdb. The solution
    > is to move the intel fb sysrq over to V for video instead of G for
    > graphics. The SMP VOYAGER code to register for the sysrq-v is not
    > anywhere to be found in the mainline kernel, so the comments in the
    > code were cleaned up as well.
    >
    > This patch also cleans up the sysrq definitions for kgdb to make it
    > generic for the kernel debugger, such that the sysrq 'g' can be used
    > in the future to enter a gdbstub or another kernel debugger.
    >

    I was looking at that a week or two ago.

    >
    > --- a/drivers/char/sysrq.c
    > +++ b/drivers/char/sysrq.c
    > @@ -406,7 +406,7 @@ static struct sysrq_key_op *sysrq_key_table[36] = {
    > &sysrq_showlocks_op, /* d */
    > &sysrq_term_op, /* e */
    > &sysrq_moom_op, /* f */
    > - /* g: May be registered by ppc for kgdb */
    > + /* g: May be registered for the kernel debugger */

    And I made the mistake of believing the comment :(


    \
     
     \ /
      Last update: 2009-05-15 01:23    [W:0.034 / U:29.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site