lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ACPI: idle: fix init-time TSC check regression
On Thu, 14 May 2009, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
>
> A previous 2.6.30 patch, a71e4917dc0ebbcb5a0ecb7ca3486643c1c9a6e2,
> (ACPI: idle: mark_tsc_unstable() at init-time, not run-time)
> erroneously disabled the TSC on systems that did not actually
> have valid deep C-states.
>
> Move the check after the deep-C-states are validated,
> via new helper, tsc_check_state(), hich replaces tsc_halts_in_c().
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> ---
> Thomas,
> I decided to use a tsc-specific helper
> rather than piggyback on acpi_timer_check_state(),
> since that is not general, but rather LAPIC timer specific.
> (and I'll re-name that to reflect its specific function
> in a cosmetic follow-up patch)

I have no strong opinion on that :)

> + if (cx->valid)
> + tsc_check_state(cx->type);
>
> if (cx->valid)
> working++;

Could do with

if (cx->valid) {
tsc_check_state(cx->type);
working++;
}
Otherwise Acked-by: Thomas Gleixner <tglx@linutronix.de>


\
 
 \ /
  Last update: 2009-05-15 00:31    [from the cache]
©2003-2011 Jasper Spaans