lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH -tip] x86: amd_iommu_init.c use NULL pointer
From
Date
On Thu, 2009-05-14 at 07:00 +0400, Cyrill Gorcunov wrote:
> On 5/14/09, Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> >
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > ---
> > arch/x86/kernel/amd_iommu_init.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kernel/amd_iommu_init.c
> > b/arch/x86/kernel/amd_iommu_init.c
> > index 8c0be09..f728b12 100644
> > --- a/arch/x86/kernel/amd_iommu_init.c
> > +++ b/arch/x86/kernel/amd_iommu_init.c
> > @@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct
> > ivmd_header *m)
> > /* called for unity map ACPI definition */
> > static int __init init_unity_map_range(struct ivmd_header *m)
> > {
> > - struct unity_map_entry *e = 0;
> > + struct unity_map_entry *e = NULL;
> >
> > e = kzalloc(sizeof(*e), GFP_KERNEL);
> > if (e == NULL)
> > --
> > 1.6.0.6
> >
> Hi Jaswinder,
> I believe you could get rid of such init completely. We do check 'e'
> after kzalloc anyway.

Thanks, here is another patch:

[PATCH -tip] x86: amd_iommu_init.c fix initialization issue

struct unity_map_entry *e = 0 which should be struct unity_map_entry *e = NULL

But we do not need to initialize e as kzalloc will take care of it.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/amd_iommu_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 8c0be09..1ca0383 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct ivmd_header *m)
/* called for unity map ACPI definition */
static int __init init_unity_map_range(struct ivmd_header *m)
{
- struct unity_map_entry *e = 0;
+ struct unity_map_entry *e;

e = kzalloc(sizeof(*e), GFP_KERNEL);
if (e == NULL)
--
1.6.0.6




\
 
 \ /
  Last update: 2009-05-14 06:45    [W:0.083 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site