lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64
Sheng Yang wrote:
>
> Yeah, this one also works well(lightly tested). :)
>
> But one thing should be noticed that, bit ops recognized the input as signed.
> According to SDM 2A 3.1.1.7 Operation Section, Bit(BitBase, BitOffset) can
> accept BitOffset as negative value, then search backward... Well, I indeed
> don't know when we need this, but I think keep signed here should be better...
>

Urk, you're right. How daft. I had preferred to switch it to unsigned
long to match MIPS and SPARC, but that probably is a good reason to
leave it signed. Pain.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2009-05-14 16:13    [W:0.083 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site