lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/4] x86-64: fix vclock_gettime()
    From
    Date
    Petr Tesarik píše v Čt 14. 05. 2009 v 15:06 +0200:
    > Now, commit cb9e35dce94a1b9c59d46224e8a94377d673e204 removed
    > rdtsc_barrier() from that function, and moved it to
    > do_vgettimeofday(). AFAICS the same is also needed for
    > vgetns(). So far so good, a one-liner should do, shouldn't it?
    > No, it won't do.

    Just to make things clear. The vDSO had been broken even before Ingo's
    commit, but the commit made the .altinstructions section go away from
    vDSO, which made the bug kind of disappear.

    I could even argue that the synchronization is not even needed, because
    this code path gets used rather often, and nobody has complained so far,
    but that's probably not the point...

    Petr Tesarik


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-05-14 15:19    [W:2.048 / U:0.980 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site