lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Fixed an off-by-one error in the AMD IOMMU driver.
    The variable amd_iommu_last_bdf holds the maximum bdf of any device
    controlled by an IOMMU, so the number of device entries needed is
    amd_iommu_last_bdf+1. The function tbl_size used amd_iommu_last_bdf
    instead. This would be a problem if the last device were a large
    enough power of 2.

    Signed-off-by: Neil Turton <nturton@solarflare.com>
    ---
    arch/x86/kernel/amd_iommu_init.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
    index 42c33ce..61479ba 100644
    --- a/arch/x86/kernel/amd_iommu_init.c
    +++ b/arch/x86/kernel/amd_iommu_init.c
    @@ -175,7 +175,7 @@ static inline void update_last_devid(u16 devid)
    static inline unsigned long tbl_size(int entry_size)
    {
    unsigned shift = PAGE_SHIFT +
    - get_order(amd_iommu_last_bdf * entry_size);
    + get_order(((int)amd_iommu_last_bdf+1) * entry_size);

    return 1UL << shift;
    }
    --
    1.5.5

    \
     
     \ /
      Last update: 2009-05-14 15:19    [W:0.020 / U:4.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site