lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 6/6] PM/Hibernate: Do not try to allocate too much memory too hard
    Hi!

    > We want to avoid attempting to free too much memory too hard during
    > hibernation, so estimate the minimum size of the image to use as the
    > lower limit for preallocating memory.

    Why? Is freeing memory too slow?

    It used to be that user controlled image size, so he was able to
    balance "time to save image" vs. "responsiveness of system after
    resume".

    Does this just override user's preference when he chooses too small
    image size?

    > The approach here is based on the (experimental) observation that we
    > can't free more page frames than the sum of:
    >
    > * global_page_state(NR_SLAB_RECLAIMABLE)
    > * global_page_state(NR_ACTIVE_ANON)
    > * global_page_state(NR_INACTIVE_ANON)
    > * global_page_state(NR_ACTIVE_FILE)
    > * global_page_state(NR_INACTIVE_FILE)
    >
    > and even that is usually impossible to free in practice, because some
    > of the pages reported as global_page_state(NR_SLAB_RECLAIMABLE) can't
    > in fact be freed. It turns out, however, that if the sum of the
    > above numbers is subtracted from the number of saveable pages in the
    > system and the result is multiplied by 1.25, we get a suitable
    > estimate of the minimum size of the image.



    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    > ---
    > kernel/power/snapshot.c | 56 ++++++++++++++++++++++++++++++++++++++++++++----
    > 1 file changed, 52 insertions(+), 4 deletions(-)


    > /**
    > + * minimum_image_size - Estimate the minimum acceptable size of an image
    > + * @saveable: The total number of saveable pages in the system.
    > + *
    > + * We want to avoid attempting to free too much memory too hard, so estimate the
    > + * minimum acceptable size of a hibernation image to use as the lower limit for
    > + * preallocating memory.

    I don't get it. If user sets image size as 0, we should free as much
    memory as we can. I just don't see why "we want to avoid... it".

    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2009-05-14 13:17    [W:0.025 / U:0.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site