lkml.org 
[lkml]   [2009]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH -tip] x86: audit.c remove unnecessary global arraysn
From
Date
On Wed, 2009-05-13 at 21:42 +0200, Thomas Gleixner wrote:
> On Thu, 14 May 2009, Jaswinder Singh Rajput wrote:
>
> > ia32_dir_class[], ia32_write_class[], ia32_read_class[], ia32_chattr_class[]
> > and ia32_signal_class[] are used only by arch/x86/kernel/audit_64.c
> > which can be replace by local variables:
> >
> > dir_class[], write_class[], read_class[], chattr_class[] and signal_class[]
>
> Groan, it can be replaced by local variables, but it does not result
> in the same functionality.
>
> These audit classes are arrays of syscall numbers, which are different
> for 32 and 64 bit. ia32/audit.c includes unistd_32.h not unistd.h for
> exactly this reason.
>

Thanks, got it :-)

--
JSR



\
 
 \ /
  Last update: 2009-05-13 21:53    [from the cache]
©2003-2011 Jasper Spaans