Messages in this thread | | | Date | Wed, 13 May 2009 21:45:51 +0200 | From | Pierre Ossman <> | Subject | Re: [PATCH] mmc_spi: do propper retry managment in the block layer |
| |
On Wed, 6 May 2009 11:45:30 +0200 Wolfgang Mües <wolfgang.mues@auerswald.de> wrote:
> > I checked the drivers sourcecode and found that most drivers are using EINVAL > for non-recoverable parameter errors. > > The only driver which uses EINVAL for errors which might result from > transmission failures is mmc_spi. > > So I think it would be OK to use another error code in mmc_spi for these > cases: > > * EILSEQ Basic format problem with the received or sent data > * (e.g. CRC check failed, incorrect opcode in response > * or bad end bit) > > Would you accept a patch to report another error code in mmc_spi? >
EILSEQ seems correct for SPI bit errors, so I'd gladly accept such a patch, yes. :)
Rgds -- -- Pierre Ossman
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. [unhandled content-type:application/pgp-signature] | |