lkml.org 
[lkml]   [2009]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled


On Wed, 13 May 2009, Alan Cox wrote:
>
> Then hard coding is no improvement either. It needs to restore the mode
> that was present at suspend.

Alan, you're missing the fact that this is a special-case for "this is the
console, and we're not suspending consoles AT ALL".

IOW, it was never suspended either, and it's a case that is known to be
fundamentally buggy (we're suspending all the PCI bridges, but not a
serial device that may be behind them!), but often work in _practice_
(because people don't use this thing for random serial devices, but for
things like integrated serial lines that don't lose power).

So we _could_ just save the mode, but that isn't really what this patch is
all about. The patch in question is about a total hack to avoid touching a
piece of hardware that we simply don't consider normal.

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [W:0.106 / U:0.920 seconds]
©2003-2014 Jasper Spaans. Advertise on this site