Messages in this thread | | | Date | Wed, 13 May 2009 09:50:09 +0900 | From | Kiyoshi Ueda <> | Subject | Re: [PATCH] swim3: use blk_end_request instead of blk_update_request |
| |
Hi,
Thank you for pointing this, Boaz!
On 2009/05/13 0:27 +0900, Tejun Heo wrote: > Hello, > > Boaz Harrosh wrote: >> blk_update_request() was meant for request-based-multi-path, and not for swim3 >> please see: >> 32fab448 block: add request update interface >> >> CC: Kiyoshi Ueda<k-ueda@ct.jp.nec.com> >> >> I think Tejun Heo was just using that in some recent block layer, >> transformation. >> Tejun? > > Yeah, conversion was easy that way. I think it's sane to have > blk_update_request() exported as long as request internal tinkering is > kept in block layer proper.
blk_update_request() is needed for request-based dm to keep the request completion ordering in bottom-up, although request-based dm is not in upstream yet.
Jens, please keep blk_update_request() exported.
Thanks, Kiyoshi Ueda
| |