lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case

    * Yinghai Lu <yinghai@kernel.org> wrote:

    > Ingo Molnar wrote:
    > > * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
    > >
    > >> [Ingo Molnar - Tue, May 12, 2009 at 01:22:05PM +0200]
    > >> |
    > >> | this build bug is still unfixed:
    > >> |
    > >> | drivers/pci/hotplug/ibmphp_core.c:165: error: expected identifier before ‘&’ token
    > >> | drivers/pci/hotplug/ibmphp_core.c:166: error: too few arguments to function ‘IO_APIC_get_PCI_irq_vector’
    > >> |
    > >> | Ingo
    > >> |
    > >>
    > >> Grrr... this line looks really suspicious inideed
    > >>
    > >> for (i = 0; i < 4; i++)
    > >> (*cur_slot)->irq[i] = IO_APIC_get_PCI_irq_vector((int) (*cur_slot)->bus,
    > >> ---> (int) (*cur_slot)->device, i.
    > >> &ioapic, &ioapic_pin,
    > >> &triggering, &polarity);
    > >>
    > >> but it's _not_ 'cause of this commit, since
    > >> we didn't even touch this file :) The point
    > >> symbol should be changed to comma. Just a
    > >> misprint I believe. Appened patch should do
    > >> the trick.
    > >
    > > Yinghai touched it:
    > >
    > > e20c06f: x86/pci: add 4 more return parameters to IO_APIC_get_PCI_irq_vector()
    > >
    > i put the fix in
    > [PATCH] x86: introduce io_apic_irq_attr -v2
    > <4A08ACD3.2070401@kernel.org>

    which is so wrong to be put into a cleanup patch ...

    anyway, i applied Cyrill's patch.

    Ingo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-05-12 17:11    [W:0.025 / U:31.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site