Messages in this thread |  | | | From | Arnd Bergmann <> | | Subject | Re: [patch 2/2] spufs: remove double check for non-negative dentry | | Date | Tue, 12 May 2009 16:15:25 +0200 |
| |
On Tuesday 05 May 2009, jblunck@suse.de wrote: > This patch removes an unnecessary double check if the dentry returned by > lookup_create() is actually non-negative. Since lookup_create() itself returns > an error in this case just remove the check. > > Signed-off-by: Jan Blunck <jblunck@suse.de>
Looks good, I'll push this one on, unless Jeremy has objections.
Thanks,
Arnd <><
> --- a/arch/powerpc/platforms/cell/spufs/inode.c > +++ b/arch/powerpc/platforms/cell/spufs/inode.c > @@ -625,10 +625,6 @@ long spufs_create(struct nameidata *nd, > if (IS_ERR(dentry)) > goto out_dir; > > - ret = -EEXIST; > - if (dentry->d_inode) > - goto out_dput; > - > mode &= ~current->fs->umask; > > if (flags & SPU_CREATE_GANG) >
|  |