lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
FromArnd Bergmann <>
SubjectRe: [patch 2/2] spufs: remove double check for non-negative dentry
DateTue, 12 May 2009 16:15:25 +0200
On Tuesday 05 May 2009, jblunck@suse.de wrote:
> This patch removes an unnecessary double check if the dentry returned by
> lookup_create() is actually non-negative. Since lookup_create() itself returns
> an error in this case just remove the check.
>
> Signed-off-by: Jan Blunck <jblunck@suse.de>

Looks good, I'll push this one on, unless Jeremy has objections.

Thanks,

Arnd <><

> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -625,10 +625,6 @@ long spufs_create(struct nameidata *nd,
> if (IS_ERR(dentry))
> goto out_dir;
>
> - ret = -EEXIST;
> - if (dentry->d_inode)
> - goto out_dput;
> -
> mode &= ~current->fs->umask;
>
> if (flags & SPU_CREATE_GANG)
>


\
 
 \ /
  Last update: 2009-05-12 16:23    [from the cache]
©2003-2010