Messages in this thread | | | Date | Tue, 12 May 2009 15:35:50 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/4] gcov: add gcov profiling infrastructure |
| |
* Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:
> Ingo Molnar wrote: >> * Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote: >> >>>>> +/* __gcov_init is called by gcc-generated constructor code for each object >>>>> + * file compiled with -fprofile-arcs. */ > [...] >> It isnt about the amount of comments, it is about the plain (and >> simple to rectify) fact that the above two-lines comment is >> inconsistent with other kernel code. > > Ok, I misunderstood when I replied. The updated patch set should contain > the correct changes though. > >>>>> $(asflags-y) $(AFLAGS_$(basetarget).o) >>>>> _cpp_flags = $(KBUILD_CPPFLAGS) $(cppflags-y) $(CPPFLAGS_$(@F)) >>>>> +# Enable gcov profiling flags for a file, directory or for all >>>>> files depending >>>>> +# on variables GCOV_PROFILE_obj.o, GCOV_PROFILE and CONFIG_GCOV_PROFILE_ALL >>>>> +# (in this order) >>>>> +ifeq ($(CONFIG_GCOV_KERNEL),y) >>>> Please try to use winged comments in makefiles too. >>> What do you mean by winged comments? >> >> This: >> >> /* >> * Comment ..... >> * ...... goes here: >> */ >> >> Is called a winged comment. Its makefile equivalent is: > > Ok. Though google disagrees on that definition (see > http://www.catb.org/~esr/jargon/html/W/winged-comments.html).
yeah, i guess you are right, the correct term would be something like 'multi-line winged comments'.
Ingo
| |