Messages in this thread | | | Date | Mon, 11 May 2009 14:45:18 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [patch 08/11 -mmotm] oom: invoke oom killer for __GFP_NOFAIL |
| |
On Mon, 11 May 2009, Andrew Morton wrote:
> > The oom killer must be invoked regardless of the order if the allocation > > is __GFP_NOFAIL, otherwise it will loop forever when reclaim fails to > > free some memory. > > We should discourage callers from using __GFP_NOFAIL at all. We should > electrocute callers for using __GFP_NOFAIL on large allocations. How's about > > WARN_ON_ONCE(order > PAGE_ALLOC_COSTLY_ORDER && > (gfp_mask & __GFP_NOFAIL)); > or, preferably: > > WARN_ON_ONCE(order > 0 && (gfp_mask & __GFP_NOFAIL)); >
Not sure it would help since the oom killer will be now be called for such an allocation and that dumps the stack (and will actually show the order and gfp flags as well).
| |