lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 08/11 -mmotm] oom: invoke oom killer for __GFP_NOFAIL
    On Sun, 10 May 2009 15:07:21 -0700 (PDT)
    David Rientjes <rientjes@google.com> wrote:

    > The oom killer must be invoked regardless of the order if the allocation
    > is __GFP_NOFAIL, otherwise it will loop forever when reclaim fails to
    > free some memory.

    We should discourage callers from using __GFP_NOFAIL at all. We should
    electrocute callers for using __GFP_NOFAIL on large allocations. How's about

    WARN_ON_ONCE(order > PAGE_ALLOC_COSTLY_ORDER &&
    (gfp_mask & __GFP_NOFAIL));
    or, preferably:

    WARN_ON_ONCE(order > 0 && (gfp_mask & __GFP_NOFAIL));

    ?


    \
     
     \ /
      Last update: 2009-05-11 23:39    [W:0.029 / U:0.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site