lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] xen: make sure swiotlb allocation is physically contigious
Joerg Roedel wrote:
>> +}
>> +
>> +void *swiotlb_alloc(unsigned order, unsigned long nslabs)
>> +{
>> + /* Never called on x86. Warn, just in case. */
>>
>
> Can't this function be removed completly then?
>

The swiotlb code contains a static call, which never ends up being
executed, so there has to be something to be called. But you're right
that there's no particular reason for this warning unless someone starts
to call swiotlb_alloc in the future.

I'd briefly discussed the idea of eliminating the distinction between
boot and post-boot swiotlb allocation, but it looks tricky to implement.

>> +
>> + if (xen_create_contiguous_region((unsigned long)buf,
>> + order, 0xffffffff))
>>
> DMA_32BIT_MASK?
>

OK (ditto other mentions).

J


\
 
 \ /
  Last update: 2009-05-11 20:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site