lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateMon, 11 May 2009 14:34:55 -0400
FromJeff Garzik <>
SubjectRe: Quick question about libata and hdparm
Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] pata_pdc202xx_old: fix UDMA33 handling
>
> The original driver doesn't use 66 MHz clock for UDMA33.
>
> [ The alternative solution would be to adjust UDMA33 timings
> for 66 MHz clock but I think that it is safer to stick with
> old & tested behavior for now. ]
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ata/pata_pdc202xx_old.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: b/drivers/ata/pata_pdc202xx_old.c
> ===================================================================
> --- a/drivers/ata/pata_pdc202xx_old.c
> +++ b/drivers/ata/pata_pdc202xx_old.c
> @@ -2,7 +2,7 @@
> * pata_pdc202xx_old.c - Promise PDC202xx PATA for new ATA layer
> * (C) 2005 Red Hat Inc
> * Alan Cox <alan@lxorguk.ukuu.org.uk>
> - * (C) 2007 Bartlomiej Zolnierkiewicz
> + * (C) 2007,2009 Bartlomiej Zolnierkiewicz
> *
> * Based in part on linux/drivers/ide/pci/pdc202xx_old.c
> *
> @@ -158,7 +158,7 @@ static void pdc2026x_bmdma_start(struct
> u32 len;
>
> /* Check we keep host level locking here */
> - if (adev->dma_mode >= XFER_UDMA_2)
> + if (adev->dma_mode > XFER_UDMA_2)
> iowrite8(ioread8(clock) | sel66, clock);
> else
> iowrite8(ioread8(clock) & ~sel66, clock);
> @@ -212,7 +212,7 @@ static void pdc2026x_bmdma_stop(struct a
> iowrite8(ioread8(clock) & ~sel66, clock);
> }
> /* Flip back to 33Mhz for PIO */
> - if (adev->dma_mode >= XFER_UDMA_2)
> + if (adev->dma_mode > XFER_UDMA_2)
> iowrite8(ioread8(clock) & ~sel66, clock);


applied



\
 
 \ /
  Last update: 2009-05-11 20:39    [from the cache]
©2003-2010