Messages in this thread | | | Date | Mon, 11 May 2009 09:49:13 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 7/7] x86/pci: update pirq_enable_irq to setup io apic routing -v2 |
| |
* Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 7 May 2009 16:12:22 +0200 > Ingo Molnar <mingo@elte.hu> wrote: > > > > > * Yinghai Lu <yinghai@kernel.org> wrote: > > > > > > > > so we could set io apic routing only when enable device irq. > > > > > > also could make setup_IO_APIC_irqs and setup_ioapic_dest only handle > > > first ioapic... > > > > > > v2: remove one one not needed style change. > > > merge the patch only setup io_apic for acpi on in > > > setup_IO_APIC_irqs > > > > > > [ Impact: make mptable irq enable more like acpi is used, and > > > numa_irq_desc could get correct node when acpi=off ] > > > > > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > > > > > --- > > > arch/x86/kernel/apic/io_apic.c | 148 > > > ++++++++++++++++++++--------------------- > > > arch/x86/pci/irq.c | 84 ++++++++--------------- 2 > > > files changed, 103 insertions(+), 129 deletions(-) > > > > Jesse, did this patch have your Acked-by? > > Yeah, both of them are fine with me. Ultimately you get to keep > any broken pieces from io_apic changes anyway, right? :)
Yeah, generally. But the wider the blame can be spread when it does break, the better! ;-)
> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Thanks!
Ingo
| |