lkml.org 
[lkml]   [2009]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 08/11 -mmotm] oom: invoke oom killer for __GFP_NOFAIL
Date
> On Mon, 11 May 2009, KOSAKI Motohiro wrote:
>
> > > The oom killer must be invoked regardless of the order if the allocation
> > > is __GFP_NOFAIL, otherwise it will loop forever when reclaim fails to
> > > free some memory.
> >
> > This is intensional behavior. plus you change very widely caller bahavior.
> > if you don't have good test program, I nak this.
> >
>
> What exactly are you objecting to? You don't want the oom killer called
> for a __GFP_NOFAIL allocation above PAGE_ALLOC_COSTLY_ORDER that could not
> reclaim any memory and would prefer that it loop endlessly in the page
> allocator? What's the purpose of that if the oom killer could free a very
> large memory hogging task?

My point is, if we change gfp-flags meaning, we should change
unintentional affected caller.

Do you oppose this?





\
 
 \ /
  Last update: 2009-05-11 03:47    [W:0.104 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site