[lkml]   [2009]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[RFC][PATCH] vmscan: don't export nr_saved_scan in /proc/zoneinfo
    The lru->nr_saved_scan's are not meaningful counters for even kernel
    developers. They typically are smaller than 32 and are always 0 for
    large lists. So remove them from /proc/zoneinfo.

    Hopefully this interface change won't break too many scripts.
    /proc/zoneinfo is too unstructured to be script friendly, and I wonder
    the affected scripts - if there are any - are still bleeding since the
    not long ago commit "vmscan: split LRU lists into anon & file sets",
    which also touched the "scanned" line :)

    If we are to re-export accumulated vmscan counts in the future, they
    can go to new lines in /proc/zoneinfo instead of the current form, or
    to /sys/devices/system/node/node0/meminfo?

    CC: Christoph Lameter <>
    Signed-off-by: Wu Fengguang <>
    mm/vmstat.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    --- mm.orig/mm/vmstat.c
    +++ mm/mm/vmstat.c
    @@ -721,7 +721,7 @@ static void zoneinfo_show_print(struct s
    "\n min %lu"
    "\n low %lu"
    "\n high %lu"
    - "\n scanned %lu (aa: %lu ia: %lu af: %lu if: %lu)"
    + "\n scanned %lu"
    "\n spanned %lu"
    "\n present %lu",
    zone_page_state(zone, NR_FREE_PAGES),
    @@ -729,10 +729,6 @@ static void zoneinfo_show_print(struct s
    - zone->lru[LRU_ACTIVE_ANON].nr_saved_scan,
    - zone->lru[LRU_INACTIVE_ANON].nr_saved_scan,
    - zone->lru[LRU_ACTIVE_FILE].nr_saved_scan,
    - zone->lru[LRU_INACTIVE_FILE].nr_saved_scan,

     \ /
      Last update: 2009-05-02 04:51    [W:0.022 / U:41.712 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site