lkml.org 
[lkml]   [2009]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v2 09/19] net: Add vbus_enet driver
    On Thu, Apr 09, 2009 at 09:37:10AM -0700, Stephen Hemminger wrote:
    > > +static int tx_ringlen = 256;
    > > +module_param(tx_ringlen, int, 0444);
    > > +
    > > +#undef PDEBUG /* undef it, just in case */
    > > +#ifdef VBUS_ENET_DEBUG
    > > +# define PDEBUG(fmt, args...) printk(KERN_DEBUG "vbus_enet: " fmt, ## args)
    > > +#else
    > > +# define PDEBUG(fmt, args...) /* not debugging: nothing */
    > > +#endif
    >
    > Why reinvent pr_debug()?

    Even more important, use dev_dbg() instead please, that uniquly
    describes your device and driver together, which is what you need/want,
    and it ties into the dynamic debug work, so you don't need a special
    kernel config option.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2009-04-09 22:11    [W:0.033 / U:1.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site