Messages in this thread | | | Date | Thu, 9 Apr 2009 19:20:55 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH -tip] x86: ftrace.c declare prepare_ftrace_return before they get used |
| |
On Thu, Apr 09, 2009 at 10:07:48PM +0530, Jaswinder Singh Rajput wrote: > Impact: fix sparse warning: > arch/x86/kernel/ftrace.c:411:6: warning: symbol 'prepare_ftrace_return' was not declared. Should it be static? > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > --- > arch/x86/include/asm/ftrace.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h > index bd2c651..49616d4 100644 > --- a/arch/x86/include/asm/ftrace.h > +++ b/arch/x86/include/asm/ftrace.h > @@ -62,4 +62,10 @@ struct dyn_arch_ftrace { > #endif /* __ASSEMBLY__ */ > #endif /* CONFIG_FUNCTION_TRACER */ > > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER > +#ifndef __ASSEMBLY__ > +extern void prepare_ftrace_return(unsigned long *, unsigned long);
But it is only used from asm code so there is no need to make its prototype public.
I don't think this is necessary but if you really think it is, then I would prefer you use the already existing #ifndef __ASSEMBLY__ block.
Thanks, Frederic.
> +#endif > +#endif > + > #endif /* _ASM_X86_FTRACE_H */ > -- > 1.6.0.6 > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |