lkml.org 
[lkml]   [2009]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] x86,apic: Checking kernel option before detect_init_APIC()
From
On Wed, Apr 8, 2009 at 8:50 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Rakib Mullick <rakib.mullick@gmail.com> wrote:
>
> Hm, are you sure this is a cleanup only? (i.e. no side-effects)
My quick review over code, i don't think there's any.Unless I'm not
missing anything. Kernel option has been passed when before kernel
starts, so I think it's safe.
>
> Also, even if it's a pure cleanup, wouldnt it be even cleaner to
> propagate this check into detect_init_APIC() - and thus get rid of
> the open-coded disable_apic check altogether?
Yes, could be. How we'll understand that whether apic has been
disabled from kernel option or not (if we requires later on)?

Rakib
>
>        Ingo
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-04-09 07:11    [W:0.141 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site