lkml.org 
[lkml]   [2009]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/12]: sparc64: Use new dynamic per-cpu allocator.
Hello,

The percpu part looks good to me. Just one question below.

David Miller wrote:
> void __init setup_per_cpu_areas(void)
> {
> - unsigned long size, i, nr_possible_cpus = num_possible_cpus();
> - char *ptr;
> + size_t dyn_size, static_size = __per_cpu_end - __per_cpu_start;
> + static struct vm_struct vm;
> + unsigned long delta, cpu;
> + size_t pcpu_unit_size;
> + size_t ptrs_size;
> +
> + pcpur_size = PFN_ALIGN(static_size + PERCPU_MODULE_RESERVE +
> + PERCPU_DYNAMIC_RESERVE);
> + dyn_size = pcpur_size - static_size - PERCPU_MODULE_RESERVE;

Isn't it better to use embedding allocator for !NUMA cases (one less
TLB entry usage for each CPU)?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-04-09 13:51    [W:0.049 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site