Messages in this thread | | | Date | Wed, 8 Apr 2009 08:51:21 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] [3/16] POISON: Handle poisoned pages in page free |
| |
> > > > /* > > + * Page may have been marked bad before process is freeing it. > > + * Make sure it is not put back into the free page lists. > > + */ > > + if (PagePoison(page)) { > > + /* check more flags here... */ > > How about adding WARNING with some information(ex, pfn, flags..).
The memory_failure() code is already quite chatty. Don't think more noise is needed currently.
Or are you worrying about the case where a page gets corrupted by software and suddenly has Poison bits set? (e.g. 0xff everywhere). That would deserve a printk, but I'm not sure how to reliably test for that. After all a lot of flag combinations are valid.
-Andi
-- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |