Messages in this thread | | | Date | Wed, 08 Apr 2009 16:16:17 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 4/7] swiotlb: Allow arch override of address_needs_mapping |
| |
FUJITA Tomonori wrote: >> Becky's patches of last week also added __weak annotations to >> swiotlb_bus_to_virt, virt_to_bus and bus_to_phys; added the hwdev >> parameter to swiotlb_bus_to_phys; and added a weak >> swiotlb_arch_address_needs_mapping. I assume that was needed because >> powerpc needs non-trivial implementations for those functions. >> > > Hmm, what she added are wrappers of virt_to_bus and bus_to_virt. We > can remove these and directly use virt_to_bus and bus_to_virt. >
In general those interfaces are deprecated. Are we un-deprecating them? Or do you mean adding virt<->bus to dma_ops?
> About __weak address_needs_mapping function, as I said, removing it > and using dma_map_ops is a proper solution. >
Fine. Could swiotlb_alloc() just call dma_alloc_coherent() too?
J
| |