lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] skge: fix occasional BUG during MTU change
    On Wed, 08 Apr 2009 16:01:52 -0700 (PDT)
    David Miller <davem@davemloft.net> wrote:

    > From: Michal Schmidt <mschmidt@redhat.com>
    > Date: Tue, 7 Apr 2009 18:36:23 +0200
    >
    > > The BUG_ON(skge->tx_ring.to_use != skge->tx_ring.to_clean) in skge_up()
    > > was sometimes observed when setting MTU.
    > >
    > > skge_down() disables the TX queue, but then reenables it by mistake via
    > > skge_tx_clean().
    > > Fix it by moving the waking of the queue from skge_tx_clean() to the
    > > other caller. And to make sure start_xmit is not in progress on another
    > > CPU, skge_down() should call netif_tx_disable().
    > >
    > > The bug was reported to me by Jiri Jilek whose Debian system sometimes
    > > failed to boot. He tested the patch and the bug did not happen anymore.
    > >
    > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
    >
    > Stephen, an ACK possibly?

    I wanted to test on real hardware, and am offsite this week.


    \
     
     \ /
      Last update: 2009-04-09 01:09    [W:0.024 / U:29.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site