lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 54/56] x86: Remove void casts

    * Jack Stone <jwjstone@fastmail.fm> wrote:

    > Ingo Molnar wrote:
    > > * Jack Stone <jwjstone@fastmail.fm> wrote:
    > >
    > >
    > >> Fixed patch
    > >>
    > >> Thanks,
    > >>
    > >
    > > Hm, what was fixed?
    > >
    > I removed casts on pointer arithmetic which probably still needed to be
    > there to do the arithmetic properly.

    ... which pretty much proves the point that these patches should not
    go via any "trivial" tree.

    Those additions of mmu pointers you did were outright lethal, i
    doubt this stuff could have booted on both 32-bit and 64-bit x86.

    Please dont do this. Or if you do, please double check your change
    and double check that the relevant vmlinux disassembly is still bit
    for bit the same.

    Ingo


    \
     
     \ /
      Last update: 2009-04-08 16:43    [W:6.643 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site