lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] ide: Add support for TRIM
    Matthew Wilcox wrote:
    > From: David Woodhouse <David.Woodhouse@intel.com>
    >
    > Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    > [modified to reduce amount of special casing needed for discard]
    > Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
    > ---
    ..
    > + task->tf.command = ATA_CMD_DSM;
    > + task->tf.feature = ATA_DSM_TRIM;
    > + task->tf.hob_feature = 0x00;
    > + task->tf.nsect = size / 512;
    > + task->tf.hob_nsect = (size / 512) >> 8;
    ..

    Matthew (or others),

    Could you perhaps explain what the purpose of the data portion
    of this command is for? The draft ATA spec I have here has mangled
    text in the description -- like it's missing a crucial sentence there.

    So it's not obvious exactly why this command even needs data to
    be transfered.

    Thanks


    \
     
     \ /
      Last update: 2009-04-08 16:35    [W:0.019 / U:48.568 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site