lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 08/56] cris: Remove void casts
    From
    On Wed, Apr 8, 2009 at 13:21, Jack Stone <jwjstone@fastmail.fm> wrote:
    > Remove uneeded void casts
    >
    > Signed-Off-By: Jack Stone <jwjstone@fastmail.fm>
    > ---
    >  arch/cris/arch-v32/drivers/cryptocop.c |    8 ++++----
    >  1 files changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
    > index 67c61ea..5d20327 100644
    > --- a/arch/cris/arch-v32/drivers/cryptocop.c
    > +++ b/arch/cris/arch-v32/drivers/cryptocop.c
    > @@ -2455,7 +2455,7 @@ static int map_pages_to_iovec(struct iovec *iov, int iovlen, int *iovix, struct
    >                        DEBUG_API(printk("map_page_to_iovec: *pageix=%d >= nopages=%d\n", *pageix, nopages));
    >                        return 0;
    >                }
    > -               iov[*iovix].iov_base = (unsigned char*)page_address(pages[*pageix]) + *pageoffset;
    > +               iov[*iovix].iov_base = page_address(pages[*pageix]) + *pageoffset;
    Pointer arithmetic or intended cast (to avoid warnings for void
    pointer arithmetic).

    >                tmplen = PAGE_SIZE - *pageoffset;
    >                if (tmplen < map_length){
    >                        (*pageoffset) = 0;
    > @@ -2780,16 +2780,16 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
    >                size_t tmplen = cop->tfrm_op.inlen;
    >
    >                cop->tfrm_op.indata[0].iov_len = PAGE_SIZE - ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
    > -               cop->tfrm_op.indata[0].iov_base = (unsigned char*)page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
    > +               cop->tfrm_op.indata[0].iov_base = page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
    Dito.

    >                tmplen -= cop->tfrm_op.indata[0].iov_len;
    >                for (i = 1; i<noinpages; i++){
    >                        cop->tfrm_op.indata[i].iov_len = tmplen < PAGE_SIZE ? tmplen : PAGE_SIZE;
    > -                       cop->tfrm_op.indata[i].iov_base = (unsigned char*)page_address(inpages[i]);
    > +                       cop->tfrm_op.indata[i].iov_base = page_address(inpages[i]);
    >                        tmplen -= PAGE_SIZE;
    >                }
    >        } else {
    >                cop->tfrm_op.indata[0].iov_len = oper.inlen - prev_ix;
    > -               cop->tfrm_op.indata[0].iov_base = (unsigned char*)page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
    > +               cop->tfrm_op.indata[0].iov_base = page_address(inpages[0]) + ((unsigned long int)(oper.indata + prev_ix) & ~PAGE_MASK);
    Dito.

    >        }
    >
    >        iovlen = nooutpages + 6;
    > --
    Bert
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-08 14:37    [W:4.159 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site