lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 51/56] sysv: Remove void casts
    From
    On Wed, Apr 8, 2009 at 14:02, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
    > On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@fastmail.fm> wrote:
    >> Remove uneeded void casts
    >>
    >> Signed-Off-By: Jack Stone <jwjstone@fastmail.fm>
    >> ---
    >>  fs/sysv/dir.c |   14 +++++++-------
    >>  1 files changed, 7 insertions(+), 7 deletions(-)
    >>
    >> diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c
    >> index 56f6552..8a9f5a7 100644
    >> --- a/fs/sysv/dir.c
    >> +++ b/fs/sysv/dir.c
    >> @@ -367,7 +367,7 @@ struct sysv_dir_entry * sysv_dotdot (struct inode *dir, struct page **p)
    >>        struct sysv_dir_entry *de = NULL;
    >>
    >>        if (!IS_ERR(page)) {
    >> -               de = (struct sysv_dir_entry*) page_address(page) + 1;
    >> +               de = page_address(page) + 1;
    > This is probably wrong, because (void* + 1) != (struct sysv_dir_entry* + 1).
    >
    Yeah, with this in mind I need to check all your patches again ;-)

    >>                *p = page;
    >>        }
    >>        return de;
    >> --
    >
    > Bert
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-08 14:17    [W:0.022 / U:61.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site