lkml.org 
[lkml]   [2009]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ftrace: Output REC->var instead of __entry->var for trace format
    On Wed, Apr 08, 2009 at 05:00:13PM +0800, Zhaolei wrote:
    > print fmt: "irq=%d return=%s", __entry->irq, __entry->ret ? \"handled\" : \"unhandled\"
    >
    > "__entry" should be convert to "REC" by __stringify() macro.
    >
    > Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
    > ---
    > kernel/trace/trace_events_stage_2.h | 4 ++--
    > 1 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/kernel/trace/trace_events_stage_2.h b/kernel/trace/trace_events_stage_2.h
    > index 9e47c39..d694a8a 100644
    > --- a/kernel/trace/trace_events_stage_2.h
    > +++ b/kernel/trace/trace_events_stage_2.h
    > @@ -108,10 +108,10 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \
    > return 0;
    >
    > #undef __entry
    > -#define __entry "REC"
    > +#define __entry REC
    >
    > #undef TP_printk
    > -#define TP_printk(fmt, args...) "%s, %s\n", #fmt, #args
    > +#define TP_printk(fmt, args...) "%s, %s\n", #fmt, __stringify(args)
    >
    > #undef TRACE_EVENT
    > #define TRACE_EVENT(call, proto, args, tstruct, assign, print) \
    > --
    > 1.5.5.3
    >
    >


    Ah indeed nice catch.
    The patch that expands stringify to multiple args looks good too.



    \
     
     \ /
      Last update: 2009-04-08 13:57    [W:0.026 / U:2.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site