lkml.org 
[lkml]   [2009]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT *] intel-iommu updates for 2.6.30 (second batch)

* David Woodhouse <dwmw2@infradead.org> wrote:

> I think the problem here is actually the fact that we used
> 'select' instead of proper dependencies. I wouldn't normally have
> used the abomination that is 'select', but since I was just moving
> things around I ended up doing so by accident.

Yeah, it's genuinely fragile.

> X2APIC currently selects INTR_REMAP, and the bug would never have
> happened if we'd made X2APIC _depend_ on INTR_REMAP instead.
>
> This is a better fix:

Yep, that patch looks better - it gets rid of a select and
establishes proper dependencies - applied it to x86/urgent
and will get it to Linus later today.

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-04-07 08:21    [W:0.054 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site