[lkml]   [2009]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] romfs: cleanup romfs_fs.h
    On Tue, Apr 07, 2009 at 07:44:17PM +0200, Christoph Hellwig wrote:
    > On Tue, Apr 07, 2009 at 07:44:57PM +0200, Sam Ravnborg wrote:
    > > On Tue, Apr 07, 2009 at 06:07:08PM +0200, Christoph Hellwig wrote:
    > > > There's no kernel-only content in it anymore, so move it to header-y
    > > > and remove the superflous #ifdef __KERNEL__.
    > >
    > > today there is no difference between header-y and unifdef-y.
    > > We pass everything through unifdef these days.
    > The __KERNEL__ removal still applies, and as long as we have two
    > different variables it should use the correct one.
    > But why do you send all through unifdef anyway? That's a pretty bad
    > signal to send when we try to get people to do cleanly seprated headers.

    We saw too many cases where headers was not assigned to unifdef-y
    after introducing "#ifdef __KERNEL__".
    So we integrated the install and unifdef step to avoid this.
    And with the header stuff in kbuild redesigned the cost was acceptable to do so.

    When I get some spare time I plan to re-implement the unifdef tool
    so it does exactly what we want it to do so we can skip the
    perl/unifdef stuff we have today.

    And I should sent a patch to Linus to get rid of unifdef-y so not to
    confuse people.


     \ /
      Last update: 2009-04-07 19:53    [W:0.020 / U:13.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site