lkml.org 
[lkml]   [2009]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [19/28] x86: MCE: Implement panic synchronization
    Date

    Impact: bugfix

    In some circumstances multiple CPUs can enter mce_panic() in parallel. This
    gives quite confused output because they will all dump the same machine check
    buffer.

    The other problem is that they would all panic in parallel, but not process
    each other's shutdown IPIs because interrupts are disabled.

    Detect this situation early on in mce_panic(). On the first CPU
    entering will do the panic, the others will just wait to be killed.

    For paranoia reasons in case the other CPU dies during the MCE I added
    a 5 seconds timeout. If it expires each CPU will panic on its own again,

    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    arch/x86/kernel/cpu/mcheck/mce_64.c | 22 ++++++++++++++++++++++
    1 file changed, 22 insertions(+)

    Index: linux/arch/x86/kernel/cpu/mcheck/mce_64.c
    ===================================================================
    --- linux.orig/arch/x86/kernel/cpu/mcheck/mce_64.c 2009-04-07 16:09:59.000000000 +0200
    +++ linux/arch/x86/kernel/cpu/mcheck/mce_64.c 2009-04-07 16:43:11.000000000 +0200
    @@ -151,10 +151,32 @@
    "and contact your hardware vendor\n");
    }

    +#define PANIC_TIMEOUT 5 /* 5 seconds */
    +
    +static atomic_t mce_paniced;
    +
    +/* Panic in progress. Enable interrupts and wait for final IPI */
    +static void wait_for_panic(void)
    +{
    + long timeout = PANIC_TIMEOUT*USEC_PER_SEC;
    + preempt_disable();
    + local_irq_enable();
    + while (timeout-- > 0)
    + udelay(1);
    + panic("Panicing machine check CPU died");
    +}
    +
    static void mce_panic(char *msg, struct mce *final, char *exp)
    {
    int i;

    + /*
    + * Make sure only one CPU runs in machine check panic
    + */
    + if (atomic_add_return(1, &mce_paniced) > 1)
    + wait_for_panic();
    + barrier();
    +
    bust_spinlocks(1);
    console_verbose();
    /* First print corrected ones that are still unlogged */

    \
     
     \ /
      Last update: 2009-04-07 17:21    [W:0.022 / U:121.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site