lkml.org 
[lkml]   [2009]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2 resend] libata-sff: avoid byte swapping in ata_sff_data_xfer()
Hello, I wrote:

> Handling of the trailing byte in ata_sff_data_xfer() is suboptimal bacause:
>
> - it always initializes the padding buffer to 0 which is not really needed in
> both the read and write cases;
>
> - it has to use memcpy() to transfer a single byte from/to the padding buffer;
>
> - it uses io{read|write}16() accessors which swap bytes on the big endian CPUs
> and so have to additionally convert the data from/to the little endian format
> instead of using io{read|write}16_rep() accessors which are not supposed to
> change the byte ordering.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

Jeff, have you forgotten about this one?

MBR, Sergei




\
 
 \ /
  Last update: 2009-04-07 11:19    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site